Theme editor

[Site News] Latest Updates V4 is Live for Public Beta

I'm getting an invalid json response when trying to filter by bookmarks.

Here's compiled triage:
- Searching "lust doll" or "indivi" causes no json response
- Since it is on page 1 of my bookmarks, it causes filters to crash
- It loads the page correctly when doing a full page load
- Cards after it are partially corrupted
- Navigating to the next page works but navigating back breaks it again
- There's an invalid character in the info description of "Lust Doll Plus" at the position where the first smart quote is

Determination: Smart quotes in LD+'s description breaks latest updates search. Click this link and then go to the previous page.

While I'm here, here are some suggestions I noticed while triaging
- Hover zone for card actions is very small. I missed it despite expecting it.
- Image counter should be visible when cycling images if enabled
- Bookmark notes should also be visible. Either an indication there is one or just the whole note. As an end-user, if I took the time to write a note, it's probably pretty important. Maybe throwing it in button's title and changing the color is probably enough
- This would be nice: (always visible bookmarks)
You must be registered to see attachments
 

Attachments

You must be registered for see attachments list
Last edited:
Thread owner
I'm getting an invalid json response when trying to filter by bookmarks.

Here's compiled triage:
- Searching "lust doll" or "indivi" causes no json response
- Since it is on page 1 of my bookmarks, it causes filters to crash
- It loads the page correctly when doing a full page load
- Cards after it are partially corrupted
- Navigating to the next page works but navigating back breaks it again
- There's an invalid character in the info description of "Lust Doll Plus" at the position where the first smart quote is

Determination: Smart quotes in LD+'s description breaks latest updates search. Click this link and then go to the previous page.

While I'm here, here are some suggestions I noticed while triaging
- Hover zone for card actions is very small. I missed it despite expecting it.
- Image counter should be visible when cycling images if enabled
- Bookmark notes should also be visible. Either an indication there is one or just the whole note. As an end-user, if I took the time to write a note, it's probably pretty important. Maybe throwing it in button's title and changing the color is probably enough
- This would be nice: (always visible bookmarks)
You must be registered to see attachments
should be fixed now.

What was happening:

- the full page load was safe because we already hardened bootJson
- the API path for filters/bookmarks was still using plain setJsonParams(...)
- one malformed smart-quote byte in a card field like the overview could make the API response invalid JSON and break bookmarks/search/page-back
I fixed that in LatestUpdates.php by:

- recursively sanitizing all JSON payload strings before sending them
- preserving valid UTF-8 as-is
- attempting recovery from Windows-1252 / ISO-8859-1 when a bad string is found
- falling back safely instead of poisoning the whole response
 
It no longer keeps the choices for filtering in/out things from 1 time to another. I ONLY want to see Ren'py and NEVER want to see 2D, kinetic novel, sandbox, fantasy, any ntr, futa or male domination.
 
Back
Top Bottom